Skip to content

Add app accounts sdk docs #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Conversation

cb-jake
Copy link
Collaborator

@cb-jake cb-jake commented Feb 21, 2025

What changed? Why?

This PR introduces App Account Docs for the Coinbase Wallet SDK

Notes to reviewers

This is a draft to introduce docs. Once the EIP is fleshed out, the overview will be updated and the new supported RPCs will be defined in their own section

How has it been tested?

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:08pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:08pm

Copy link

vercel bot commented Feb 21, 2025

@cb-jake is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 21, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

vercel bot commented Feb 27, 2025

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@cb-jake cb-jake requested review from ericbrown99 and wbnns February 27, 2025 17:14
@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2025-02-27 18:36:28 UTC
User failed mfa authentication, see go/mfa-help

@brendan-defi brendan-defi merged commit 933aff1 into base:master Feb 27, 2025
4 of 6 checks passed
ARYZEofficial pushed a commit to ARYZEofficial/base-web that referenced this pull request Mar 7, 2025
* Add SDK docs for sub accounts

* rename to sub vs app

* Apply suggestions from code review

Co-authored-by: wilsoncusack <[email protected]>

* make sub account a pronoun

* add link to reference

---------

Co-authored-by: wilsoncusack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants